feat: add drop_index #3382
Merged
feat: add drop_index #3382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuQQiu
approved these changes
Jan 14, 2025
python/python/lance/dataset.py
Outdated
| @@ -2222,6 +2222,16 @@ def create_index( | |||
| ) | |||
| return self | |||
|
|
|||
| def drop_index(self, column: str, name: str): | |||
There was a problem hiding this comment.
is column required? or solely name is enough?
There was a problem hiding this comment.
Good point. I didn't realize index names were unique but after some testing it appears this is the case. So the name should be all we need 🎉
I'll fix the PR.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3382 +/- ##
==========================================
- Coverage 78.47% 78.46% -0.01%
==========================================
Files 250 250
Lines 90243 90433 +190
Branches 90243 90433 +190
==========================================
+ Hits 70817 70960 +143
- Misses 16521 16557 +36
- Partials 2905 2916 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helpful for when an index is created by mistake or no longer needed.